Skip to content

add support for FOR ORDINALITY and NESTED in JSON_TABLE #1493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 6, 2024
Merged

add support for FOR ORDINALITY and NESTED in JSON_TABLE #1493

merged 4 commits into from
Nov 6, 2024

Conversation

lovasoa
Copy link
Contributor

@lovasoa lovasoa commented Oct 30, 2024 •
edited
Loading

fixes #1492

see the specs here: https://dev.mysql.com/doc/refman/8.0/en/json-table-functions.html#function_json-table

@alamb : this is a fix for the following bug in SQLPage: sqlpage/SQLPage#658

@lovasoa lovasoa marked this pull request as ready for review October 30, 2024 22:02
@lovasoa lovasoa changed the title add support for FOR ORDINALITY in JSON_TABLE add support for FOR ORDINALITY and NESTED in JSON_TABLE Oct 30, 2024
@lovasoa lovasoa mentioned this pull request Oct 30, 2024
Closed
iffyio
iffyio approved these changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@iffyio iffyio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! cc @alamb

@coveralls
Copy link

Pull Request Test Coverage Report for Build 11621463747

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 27 of 29 (93.1%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.003%) to 89.382%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/ast/query.rs 10 12 83.33%
Totals Coverage Status
Change from base Build 11580333290: 0.003%
Covered Lines: 30439
Relevant Lines: 34055
💛 - Coveralls

@alamb alamb merged commit fc0e13b into apache:main Nov 6, 2024
10 checks passed
@alamb
Copy link
Contributor

alamb commented Nov 6, 2024

Thanks @lovasoa and @iffyio

@lovasoa lovasoa deleted the json_table_advanced_column_types branch November 6, 2024 21:06
@lovasoa
Copy link
Contributor Author

lovasoa commented Nov 6, 2024

Thank you for merging, @alamb 😊

Could you maybe also take a look at #1490 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iffyio iffyio iffyio approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add support for FOR ORDINALITY in JSON_TABLE

4 participants

@lovasoa @coveralls @alamb @iffyio